Repository navigation
Resize Upstream PR Review Comment - #124
Merged
Merged
Conversation
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.85% |
| Branch coverage | 19.01% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
approved these changes
Oct 16, 2026
sandeeplocharla
left a comment
sandeeplocharla
left a comment
Collaborator
There was a problem hiding this comment.
Isn't there any test case for this?
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.80% |
| Branch coverage | 20.07% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
suryag1201
force-pushed
the
bugfix/CSTACKEX-356
branch
from
October 16, 2026 13:12
01ca16b to
62ad46e
Compare
Author
added |
rajiv-jain-netapp
approved these changes
Oct 29, 2026
sp16743
approved these changes
Oct 29, 2026
suryag1201
added a commit
that referenced
this pull request
Oct 30, 2026
### Description Root Volume created with custom IOPS and not overridden by the custom disk offering should also show the min and max IOPS on form <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): <img width="655" height="529" alt="image" src="https://github.com/user-attachments/assets/335b1c6c-e979-4976-a7a3-1c1b52f535e7" /> <img width="526" height="407" alt="image" src="https://github.com/user-attachments/assets/76a5e0e5-ec23-4b0f-96ea-ee43c81cfa44" /> <img width="599" height="460" alt="image" src="https://github.com/user-attachments/assets/923c44a5-b53f-452f-944c-73ef3c75d804" /> ### How Has This Been Tested? 1- Created a Fix IOPS Offering of compute/disk and use to create VM/Volume, resize should not show min max IOPS - success 2- Created a Custom IOPS Offering of compute/disk and use to create VM/Volume, resize should show min max IOPS - success #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
suryag1201
added a commit
that referenced
this pull request
Oct 30, 2026
Root Volume created with custom IOPS and not overridden by the custom disk offering should also show the min and max IOPS on form <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) - [x] Major - [ ] Minor - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial <img width="655" height="529" alt="image" src="https://github.com/user-attachments/assets/335b1c6c-e979-4976-a7a3-1c1b52f535e7" /> <img width="526" height="407" alt="image" src="https://github.com/user-attachments/assets/76a5e0e5-ec23-4b0f-96ea-ee43c81cfa44" /> <img width="599" height="460" alt="image" src="https://github.com/user-attachments/assets/923c44a5-b53f-452f-944c-73ef3c75d804" /> 1- Created a Fix IOPS Offering of compute/disk and use to create VM/Volume, resize should not show min max IOPS - success 2- Created a Custom IOPS Offering of compute/disk and use to create VM/Volume, resize should show min max IOPS - success change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root Volume created with custom IOPS and not overridden by the custom disk offering should also show the min and max IOPS on form
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
1- Created a Fix IOPS Offering of compute/disk and use to create VM/Volume, resize should not show min max IOPS - success
2- Created a Custom IOPS Offering of compute/disk and use to create VM/Volume, resize should show min max IOPS - success
How did you try to break this feature and the system with this change?